Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace CacheHttp with &Http in more methods #2818

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Replace CacheHttp with &Http in more methods #2818

merged 1 commit into from
Mar 28, 2024

Conversation

GnomedDev
Copy link
Member

This is possible now more methods are cache-less.

@github-actions github-actions bot added model Related to the `model` module. builder Related to the `builder` module. examples Related to Serenity's examples. labels Mar 26, 2024
@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Mar 28, 2024
@arqunis arqunis merged commit 71550cb into serenity-rs:next Mar 28, 2024
21 checks passed
@GnomedDev GnomedDev deleted the replace-cachehttp branch March 28, 2024 13:05
GnomedDev added a commit that referenced this pull request Mar 29, 2024
@GnomedDev
Replace CacheHttp with &Http in more methods (#2818)
3d8c54a 
This is possible now more methods are cache-less.
GnomedDev added a commit that referenced this pull request Mar 31, 2024
@GnomedDev
Replace CacheHttp with &Http in more methods (#2818)
0479021 
This is possible now more methods are cache-less.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 31, 2024
@GnomedDev
Replace CacheHttp with &Http in more methods (serenity-rs#2818)
07fbcdb 
This is possible now more methods are cache-less.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Apr 1, 2024
@GnomedDev
Replace CacheHttp with &Http in more methods (serenity-rs#2818)
36704dd 
This is possible now more methods are cache-less.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@GnomedDev
Replace CacheHttp with &Http in more methods (serenity-rs#2818)
fe0067e 
This is possible now more methods are cache-less.
GnomedDev added a commit that referenced this pull request May 14, 2024
@GnomedDev
Replace CacheHttp with &Http in more methods (#2818)
e6a04cb 
This is possible now more methods are cache-less.
GnomedDev added a commit that referenced this pull request May 23, 2024
@GnomedDev
Replace CacheHttp with &Http in more methods (#2818)
ce9d21f 
This is possible now more methods are cache-less.
GnomedDev added a commit that referenced this pull request May 28, 2024
@GnomedDev
Replace CacheHttp with &Http in more methods (#2818)
9fe892c 
This is possible now more methods are cache-less.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@GnomedDev
Replace CacheHttp with &Http in more methods (serenity-rs#2818)
998ebae 
This is possible now more methods are cache-less.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users builder Related to the `builder` module. enhancement An improvement to Serenity. examples Related to Serenity's examples. model Related to the `model` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GnomedDev @arqunis