Add support for Message Polls #2836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arqunis
added
enhancement
|
@GnomedDev Can this be merged ASAP since it's already out and I want to add stuff to my bot related to polls |
|
No? It doesn't work as-is and I haven't implemented much anyway. If you want to take over this PR, feel free, but I'm not paid to work on serenity so I will work when I feel like it. |
Oh alright, sorry for the comment btw |
|
This is ready for review, I've tested the happy paths but it may need a bit more testing, this can be done after merge though as it's not like we are pushing a release right after. |
arqunis
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Polls attached to messages. This has been tested for deserialising, creating, getting answer voters, and ending a poll.
The builder is designed differently, as there are many required fields, so I used the typestate pattern to prevent the user from using the builder until it is ready.