Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore match arm for Error::Gateway variant #2847

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

mkrasnitski
Copy link
Collaborator

This was mistakenly removed in #2278 and wasn't caught because of the wildcard pattern in the match.

@GnomedDev
Copy link
Member

Can you spell out the variants being caught by the wildcard, so this doesn't happen again?

@mkrasnitski
Copy link
Collaborator Author

I removed the wildcard, so there are no extra variants being caught by it anymore.

Copy link
Member

@GnomedDev GnomedDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm silly!

@GnomedDev GnomedDev merged commit 39a0574 into serenity-rs:next Apr 22, 2024
21 checks passed
@arqunis arqunis added the fix A solution to an existing bug. label Apr 22, 2024
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
This was mistakenly removed in serenity-rs#2278 and wasn't caught because of the
wildcard pattern in the match.
GnomedDev pushed a commit that referenced this pull request May 14, 2024
This was mistakenly removed in #2278 and wasn't caught because of the
wildcard pattern in the match.
GnomedDev pushed a commit that referenced this pull request May 23, 2024
This was mistakenly removed in #2278 and wasn't caught because of the
wildcard pattern in the match.
GnomedDev pushed a commit that referenced this pull request May 28, 2024
This was mistakenly removed in #2278 and wasn't caught because of the
wildcard pattern in the match.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
This was mistakenly removed in serenity-rs#2278 and wasn't caught because of the
wildcard pattern in the match.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A solution to an existing bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants