Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[routing] Fix various incorrect routes. #364

Merged
1 commit merged into from Aug 9, 2018
Merged

[routing] Fix various incorrect routes. #364

1 commit merged into from Aug 9, 2018

Conversation

Lymia
Copy link
Contributor

@Lymia Lymia commented Aug 9, 2018

No description provided.

@ghost ghost merged commit 826220f into serenity-rs:master Aug 9, 2018
@ghost
Copy link

ghost commented Aug 9, 2018

Thanks

@iddm
Copy link
Contributor

iddm commented Aug 9, 2018

I am curious, why these changes were needed? Did it work earlier? Did discord api change? There is no description at all.

@Mishio595
Copy link
Contributor

@vityafx See this commit that abstracted routing methods

@iddm
Copy link
Contributor

iddm commented Aug 9, 2018

@Mishio595 Thanks. I think it is still good to write a description for the changes, both in commit and in pull request.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Lymia @iddm @Mishio595