Implement command groups #40
Conversation
| .group("emoji", |g| | ||
| .command("cat", |c| c | ||
| .exec_str(":cat:") | ||
| .required_permissions(permissions::SEND_MESSAGES)) |
There was a problem hiding this comment.
It was probably a mistake of mine to use this permission as an example previously; maybe ADMINISTRATOR?
| min_args: None, | ||
| max_args: None, | ||
| required_permissions: Permissions::empty() | ||
| })); |
There was a problem hiding this comment.
This is used elsewhere as well. Maybe Command could use a new method with exec as the argument and setting everything else listed here as the defaults.
| pub fn on<F, S>(mut self, command_name: S, f: F) -> Self | ||
| where F: Fn(&Context, &Message, Vec<String>) + Send + Sync + 'static, | ||
| S: Into<String> { | ||
|
|
| pub fn command<F, S>(mut self, command_name: S, f: F) -> Self | ||
| where F: FnOnce(CreateCommand) -> CreateCommand, | ||
| S: Into<String> { | ||
|
|
| use ::model::Permissions; | ||
| use std::sync::Arc; | ||
|
|
||
| pub struct CreateGroup(pub CommandGroup); |
|
|
||
| permissions_fulfilled = perms.contains(command.required_permissions); | ||
| permissions_fulfilled = perms.contains(command.required_permissions); |
There was a problem hiding this comment.
Side-note: the indentation here has gotten a little insane.
Note-to-self: revise this later
| required_permissions: Permissions::empty() | ||
| })); | ||
| if !self.groups.contains_key("Ungrouped") { | ||
| self.groups.insert("Ungrouped".to_string(), Arc::new(CommandGroup { |
There was a problem hiding this comment.
Arc::new(CommandGroup::default()) to simplify things a bit
| @@ -395,7 +422,31 @@ impl Framework { | |||
| where F: FnOnce(CreateCommand) -> CreateCommand, | |||
| S: Into<String> { | |||
| let cmd = f(CreateCommand(Command::default())).0; | |||
| self.commands.insert(command_name.into(), Arc::new(cmd)); | |||
| if !self.groups.contains_key("Ungrouped") { | |||
| self.groups.insert("Ungrouped".to_string(), Arc::new(CommandGroup { | |||
| } | ||
|
|
||
| self | ||
| } |
There was a problem hiding this comment.
Although I don't think semver requires this for versions < 1.0.0, it'd be nice to remove this only once we hit v0.2.0, rather than the v0.1.2 that the next version is planned to be. Is it possible to keep this?
| min_args: None, | ||
| max_args: None, | ||
| required_permissions: Permissions::empty() | ||
| })); |
There was a problem hiding this comment.
This could also make use of the proposed Command::new from above
ghost
merged commit 
ghost
mentioned this pull request
No description provided.