Fix Help displaying Groups and their Commands #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added tests ensuring the order.
A trait offering access to fields that both `CommandOptions` and `GroupOptions` have in common and are required for other functions. They can now operate over the same type with the same implementation.
If a higher ranked group applies an effect to its commands, it will propagate the effect to its sub-groups.
Lakelezz
added
fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests fixes the behaviour for groups to properly propagate their text-effects to sub-groups.
Empty groups will not be displayed. Therefore, if all commands are hidden, the group will be hidden and all of its sub-groups will be hidden too.