Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice: add infinite retry arg to ytdl for rst packets #578

Merged
merged 1 commit into from
May 25, 2019

Conversation

Flat
Copy link
Member

@Flat Flat commented May 25, 2019

Youtube periodically will send rst packets to drop the connection
likely due to the slow download rate as it is piped directly into ffmpeg
to play. The default number of retries is 10 which will abort playback
in long tracks after 10 errors. This commit sets the max retries to
infinite.

Youtube periodically will send rst packets to drop the connection
likely due to the slow download rate as it is piped directly into ffmpeg
to play. The default number of retries is 10 which will abort playback
in long tracks after 10 errors. This commit sets the max retries to
infinite.
@arqunis arqunis added fix A solution to an existing bug. voice Related to the `voice` module and `serenity_voice_model` crate. labels May 25, 2019
@arqunis arqunis merged commit 86ec810 into serenity-rs:v0.6.x May 25, 2019
@Flat Flat deleted the voice-ytdl-rst-fix branch June 9, 2019 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A solution to an existing bug. voice Related to the `voice` module and `serenity_voice_model` crate.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants