Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cached's Name and Documentation #594

Merged
merged 2 commits into from
Jun 3, 2019

Conversation

Lakelezz
Copy link
Contributor

@Lakelezz Lakelezz commented Jun 2, 2019

The event cached is not very accurate on its meaning and its documentation is ambiguous. It referred to when the cache gets full, which can be interpreted as the cache reaching its maximum possible volume/size.

This pull request attempts to improve the naming and documentation.

@Lakelezz Lakelezz added enhancement An improvement to Serenity. client Related to the `client` module. labels Jun 2, 2019
@Lakelezz Lakelezz added this to the 0.6 milestone Jun 2, 2019
@arqunis arqunis changed the title Improve cached's Name and Documenation Improve cached's Name and Documentation Jun 3, 2019
@arqunis arqunis merged commit 7706475 into serenity-rs:v0.6.x Jun 3, 2019
@Lakelezz Lakelezz deleted the improve-cached-name-and-docs branch June 3, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Related to the `client` module. enhancement An improvement to Serenity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants