Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Apollo GraphQL packages #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sergVedmak
Copy link
Owner

@sergVedmak sergVedmak commented Dec 1, 2021

This PR contains the following updates:

Package Type Update Change
@apollo/gateway dependencies minor 0.35.1 -> 0.44.1
@apollo/subgraph dependencies patch 0.1.0 -> 0.1.5

Release Notes

apollographql/federation

v0.44.1

Compare Source

v0.44.0

Compare Source

v0.43.1

Compare Source

v0.43.0

Compare Source

v0.42.3

Compare Source

  • Updates to transitive dependencies. No other substantial changes.

v0.42.2

Compare Source

  • Updates to transitive dependencies. No other substantial changes.

v0.42.1

Compare Source

  • Emit a deprecation warning for deprecated functions. We would advise to adjust the code to use the new functionality, as the deprecated functions will be removed in a future version. If needed, deprecation warnings can be muted with either the --no-deprecation or --no-warnings command-line flags for node.js. Please keep in mind in doing so will also prevent any future deprecation warnings from node.js itself as well as from any package.PR #​1033.

v0.42.0

Compare Source

  • Only related changes in the @apollo/federation package. Adds flexibility for @​tag directive definitions in subgraphs.

v0.41.0

Compare Source

  • BREAKING: This is a breaking change due to a peerDependencies update (graphql@^15.4.0 -> graphql@^15.5.3). This graphql version includes a fix which is being necessarily adopted within the @apollo/federation package. See associated CHANGELOG entry in the federation-js folder for additional details. PR #​1008

v0.40.0

Compare Source

  • Only related changes in the @apollo/federation package. Adds support for @deprecated on input values and the new built-in directive @specifiedBy.

v0.39.0

Compare Source

  • Introduce @core/v0.2 support with the for: directive argument which was introduced to the core specification in specs-core#​9. Supergraphs (which are @core schemas in the way they're implemented) which were generated with a composer tool (e.g., rover) that produces @core schemas with the v0.1 specification are still valid and backwards compatible. The newly introduced for: argument allows a @core directive to specify its criticality to the gateway (or any consumer). The for: argument is optional - its absence means that the directive requires no additional support from the consumer. Its two available options EXECUTION and SECURITY both require explicit support from the consumer, else the consumer should fail to start / update to this unsupported schema. For more information on supergraphs see our documentation or learn how to generate them in our federation quickstart. PR #​957

v0.38.2

Compare Source

v0.38.1

Compare Source

  • Reverts PR #​159 which propogated subgraph execution errors directly to the client. While desirable in practice, this somewhat recent introduction would seem to beg for a different implementation, given that the pain points of introducing it seem to be currently outweighing the gains. Happy to revisit this with additional feedback on the tracking issue that has been opened to re-visit this. In the interim, we are offering a release that reverts this change. Issue #​974 Apollo Server Issue #​5550 PR #​982

v0.38.0

Compare Source

v0.37.0

Compare Source

  • OpenTelemetry will now include the GraphQL operationName in span attributes, following up on the initial implementation introduced in v0.31.0 via #​836 PR #​942

v0.36.0

Compare Source

  • In RemoteGraphQLDataSource, if the subgraph response has a cache-control header, use it to affect the current request's overall cache policy. You can disable this by passing honorSubgraphCacheControlHeader: false to the RemoteGraphQLDataSource constructor. This feature is only enabled when your subgraph is running Apollo Server 3.0.2 or later. PR #​870 Related docs PR
  • Provide the full incoming GraphQLRequestContext to GraphQLDataSource.process, as well as a kind allowing your implementation to differentiate between requests that come from incoming GraphQL operations, health checks, and schema fetches. PR #​870 Issue #​419 Issue #​835

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

@setchy
Copy link

setchy commented Dec 2, 2021

@sergVedmak - between the time I created my renovate-bot-testbed-apollo repo and now, Apollo restructured their monorepo and removed the @apollo/federation package.

I've just pushed an upstream change which should better test your enhancements to release note handling.

@sergVedmak sergVedmak force-pushed the renovate/apollo-graphql-packages branch from 4d70e7d to 60c5762 Compare December 2, 2021 13:12
@sergVedmak
Copy link
Owner Author

@setchy looks like problem with apollo monorepo still exist, but with emotion all works good here sergVedmak/emotion-renovate-2#2

@setchy
Copy link

setchy commented Dec 2, 2021

Hmm... How odd

@sergVedmak
Copy link
Owner Author

I will try to debug later

@sergVedmak
Copy link
Owner Author

@setchy I found the problem with apollo - there is no release notes for target version in changelog.md file. In that PR renovate try to update @apollo/gateway to 0.44.1, but in there in no notes for 0.44.1 in file https://github.com/apollographql/federation/blob/main/gateway-js/CHANGELOG.md. It's the same with @apollo/subgraph

De-duplicate logic(here is an explanation of the problem renovatebot/renovate#12543 (comment)) - https://github.com/renovatebot/renovate/blob/main/lib/workers/pr/index.ts#L322 take repo sourceUrl, because releaseNotes for target version is empty. Repo sourceUrl for @apollo/subgraph and @apollo/gateway is equals, and release notes for @apollo/subgraph hiding

@setchy
Copy link

setchy commented Dec 2, 2021

Thanks for helping to triage @sergVedmak.

I've raised apollographql/federation#1263 and shared with the Apollo team to investigate/fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants