Bugfix for webpack paths #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way our code currently deals with multiple webpack directories (as it joins and splits them by ':') doesn't work very well with Windows paths that have semicolon in their path (C:\path\to\dir). So changing this to ';' which should be good for both Windows and *nix.
Closed
|
Verified on my end in a *nix environment and all looks good. Well done @iafan 👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the build process more Windows-friendly and doesn't result in odd errors like missing 'C:\manifest.json' file caused by incorrect path splitting.
It also prevents Webpack chunks to be created under odd directory names, like
pootle/static/js/11../11/app.bundle.js. With that change the path is expected to be justpootle/static/js/11/app.bundle.jswhere11is a chunk ID (we have a bunch of these).Supersedes #2.