Test _FORTIFY_SOURCE=3 #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the glibc patchset to verify results: https://sourceware.org/pipermail/libc-alpha/2020-December/120610.html |
Mark failures and continue execution of the testsuite. Display a summary at the end of each compiler run.
I have added a proposal in glibc to implement a new fortification level _FORTIFY_SOURCE=3 which enables potentially more expensive hardening, as is done by __builtin_dynamic_object_size. This patch adds support in tests for allocating the buffer dynamically and then testing _FORTIFY_SOURCE=3 with them. The current state is that with upstream clang and gcc, all of the tests fail with _FORTIFY_SOURCE=3. With the glibc changes to add _FORTIFY_SOURCE=3, clang passes all tests because it has __builtin_dynamic_object_size.
|
Rebased over #10 to allow the test to run to completion. |
|
|
|
@siddhesh : could you rebase your patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a proposal in glibc to implement a new fortification level _FORTIFY_SOURCE=3 which enables potentially more expensive hardening, as is done by
__builtin_dynamic_object_size. This patch adds support in tests for allocating the buffer dynamically and then testing_FORTIFY_SOURCE=3with them.The current state is that with upstream clang and gcc, all of the tests fail with
_FORTIFY_SOURCE=3. With the glibc changes to add_FORTIFY_SOURCE=3(I'll post the final patches soon), clang passes all tests because it has__builtin_dynamic_object_size.This change is actually just one commit, the other three commits belong to the other two PRs.