-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/isoneutral #1951
Merged
Merged
Fix/isoneutral #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the following: #pythran export foo(int, int,)
cc @ashwinvis |
ashwinvis
added a commit
to ashwinvis/pyhpc-benchmarks
that referenced
this pull request
Jan 1, 2022
The serge-sans-paille/pythran#1951 PR has fixed nearly all issues with this benchmark pip install -e 'git+https://github.com/serge-sans-paille/pythran.git@fix/isoneutral#egg=pythran' Commit: serge-sans-paille/pythran@d305e4a
It works. Thanks! |
Some cases were not properly handled, which prevented correct compilation of an interesting test case from https://github.com/dionhaefner/pyhpc-benchmarks/blob/master/benchmarks/isoneutral_mixing
8b4f724
to
4dd3498
Compare
@ashwinvis and what about the speedup? |
Some numbers:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.