Pythran file #647
Pythran file #647
Conversation
pythran/spec.py
Outdated
| .replace('#', '') | ||
| .replace('\_o< pythran >o_/', '#pythran')) | ||
| else: | ||
| pythran_data = "\n".join(['#pythran ' + str(a) for a in data.split("\n")]) |
There was a problem hiding this comment.
you're not filtering out empty lines, so
foo(int)
foo(str)
will cause an error
pythran/spec.py
Outdated
| @@ -316,5 +319,5 @@ def specs_to_docstrings(specs, docstrings): | |||
| ) | |||
|
|
|||
|
|
|||
| def spec_parser(path): | |||
| return SpecParser()(path) | |||
| def spec_parser(path, python_file=True): | |||
There was a problem hiding this comment.
I would feel more comfortable with a subclass of SpecParser that just overrides the right method, putting shared code where it's meant to be, instead of this ugly boolean
| with open(path_or_text) as fd: | ||
| pythrancode = fd.read() | ||
| else: | ||
| pythrancode = path_or_text |
There was a problem hiding this comment.
if you do it here, maybe you can remove the file_or_path from the spec.py file
There was a problem hiding this comment.
The point is to have the filepath inside spec.py in order to have the file path in the error message
There was a problem hiding this comment.
BTW, shouldn't we replace non #pythran line by empty line in order to avoid wrong line information?
pythran/toolchain.py
Outdated
| spec_file = os.path.join(dirname, module_name + ".pythran") | ||
| if os.path.isfile(spec_file): | ||
| from pythran.spec import spec_parser | ||
| specs = spec_parser(spec_file, False) |
There was a problem hiding this comment.
here, instead of the bool, you would use an aux_spec_parser that crates the deriving object etc
| from pythran.spec import spec_parser | ||
| specs = spec_parser(spec_file, False) | ||
|
|
||
| output_file = compile_pythrancode(module_name, file_path, specs, | ||
| output_file=output_file, | ||
| cpponly=cpponly, | ||
| **kwargs) |
There was a problem hiding this comment.
I don't see a single test case :-)
diorcety
force-pushed
the
pythran_file
branch
4 times, most recently
from
629d9ef
to
e15ad97
Compare
pythran/spec.py
Outdated
| .replace('#', '')) | ||
|
|
||
| SpecParser._parse(self, pythran_data) | ||
|
|
There was a problem hiding this comment.
I really prefer tis version \o/
pythran/toolchain.py
Outdated
| @@ -343,18 +349,24 @@ def compile_pythranfile(file_path, output_file=None, module_name=None, | |||
| """ | |||
| if not output_file: | |||
| # derive module name from input file name | |||
| _, basename = os.path.split(file_path) | |||
| dirname, basename = os.path.split(file_path) | |||
There was a problem hiding this comment.
dirname is unsued later, so better keep _?
diorcety
force-pushed
the
pythran_file
branch
3 times, most recently
from
6868536
to
916b43b
Compare
|
Moved to #656 |
No description provided.