-
Notifications
You must be signed in to change notification settings - Fork 52
@Subscribe visibility? #31
Comments
This was an explicit design decision. The reason for that is that future versions of TinyBus may use generated code instead of runtime reflection. Keeping methods public will give more flexibility if case of such changes in the future. |
Make sense. Would be nice to generate a warning though ;) |
You mean when a method is private of protected? On Mon, Mar 9, 2015 at 4:48 PM, nono240 notifications@github.com wrote:
|
Yes, at compile time of course - at least for Android Studio. Dagger raise an error is the field is private. |
Agree. That what I was thinking about. I didn't want to introduce these checks at runtime. But it's a good idea to have them at compile time. Just created a separate TODO for it. |
It would be nice to be able to use private/protected/package methods as @subscribe... Public methods are pollutions.
The text was updated successfully, but these errors were encountered: