feat: improved memory consumption for PresentationBuilder.PublishSlides

sergey-tihon · Dec 16, 2021 · d8d931a · d8d931a
1 parent ad8ce1e
commit d8d931a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/OpenXmlPowerTools/PowerPoint/FluentPresentationBuilder.cs b/OpenXmlPowerTools/PowerPoint/FluentPresentationBuilder.cs
@@ -301,6 +301,9 @@ public void AppendSlides(PresentationDocument sourceDocument, int start, int cou
                 var newSlide = _newDocument.PresentationPart.AddNewPart<SlidePart>();
                 var slideDocument = slide.GetXDocument();
 
+                // cached annotation should be removed because it will be used in a new slide
+                slide.RemoveAnnotations<XDocument>();
+
                 // If we extract one slide, this slide should be visible
                 slideDocument.Root?.Attribute(NoNamespace.show)?.Remove();
 

diff --git a/OpenXmlPowerTools/PowerPoint/PresentationBuilder.cs b/OpenXmlPowerTools/PowerPoint/PresentationBuilder.cs
@@ -85,16 +85,17 @@ public static IList<PmlDocument> PublishSlides(PmlDocument src)
 
         public static IEnumerable<PmlDocument> PublishSlides(PresentationDocument srcDoc, string fileName)
         {
-            var slideList = srcDoc.PresentationPart.GetXDocument().Root.Descendants(P.sldId).ToList();
-            for (var slideNumber = 0; slideNumber < slideList.Count; slideNumber++)
+            var slidesCount = srcDoc.PresentationPart.GetXDocument().Root.Descendants(P.sldId).Count();
+            for (var slideNumber = 0; slideNumber < slidesCount; slideNumber++)
             {
                 using var streamDoc = OpenXmlMemoryStreamDocument.CreatePresentationDocument();
-                using (var output = streamDoc.GetPresentationDocument(new OpenSettings { AutoSave = false}))
+                using (var output = streamDoc.GetPresentationDocument(new OpenSettings { AutoSave = false }))
                 {
                     ExtractSlide(srcDoc, slideNumber, output);
 
-                    var slidePartId = slideList.ElementAt(slideNumber).Attribute(R.id)?.Value;
-                    var slidePart = (SlidePart)srcDoc.PresentationPart.GetPartById(slidePartId);
+                    var slides = output.PresentationPart.GetXDocument().Root.Descendants(P.sldId);
+                    var slidePartId = slides.ElementAt(0).Attribute(R.id)?.Value;
+                    var slidePart = (SlidePart)output.PresentationPart.GetPartById(slidePartId);
                     output.PackageProperties.Title = PresentationBuilderTools.GetSlideTitle(slidePart);
                 }