refactor: amend the reducer type

sergeysova · Oct 15, 2019 · bce8d1d · bce8d1d
1 parent daacb43
commit bce8d1d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/types/index.d.ts b/types/index.d.ts
@@ -14,7 +14,11 @@ export type Symbiotes<State> = {
   [Key in any]: Symbiote<State, any[]> | Symbiotes<State>;
 };
 
-export type Reducer<State> = (state: State, action: Action<any[]>) => State;
+interface BasicAction {
+  type: string | number | symbol;
+}
+
+export type Reducer<State> = (state: State, action: BasicAction) => State;
 
 export type ActionCreator<TSymbiote> = TSymbiote extends Symbiote<any, infer Arguments>
   ? (...payload: Arguments) => Action<Arguments>

diff --git a/types/test.ts b/types/test.ts
@@ -25,8 +25,9 @@ interface PlainActionCreators {
 {
   // Works correct with plain state and actions
 
+  const initialState = { count: 0 };
   const { actions, reducer } = createSymbiote(
-    { count: 0 },
+    initialState,
     {
       inc: (state: PlainState) => ({ ...state, count: state.count + 1 }),
       dec: (state: PlainState) => ({ ...state, count: state.count + 1 }),
@@ -37,7 +38,8 @@ interface PlainActionCreators {
   reducer as Reducer<PlainState>;
 
   actions.inc();
-  actions.dec();
+  reducer(initialState, actions.dec());
+  reducer(initialState, { type: 'other' });
 }
 {
   // Throw error if the initial state type doesn't match the symbiotes state type