This repository has been archived by the owner on Sep 16, 2020. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 9
Types: derive actions type from the symbiotes type #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepCode Report (#bce8d1)DeepCode analyzed this pull request. |
sergeysova
approved these changes
Oct 18, 2019
Have you finished? |
Yes |
Thank you |
@all-contributors please add @Finesse for code |
I've put up a pull request to add @Finesse! 🎉 |
@sergeysova How to get my $5 from IssueHunt? |
@Finesse done |
@sergeysova Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #28
Sorry for the long delay, I was quite busy.
Now one doesn't need to write the action types, TypeScript does it automatically:
I failed to implement the symbiotes optional arguments support in TypeScript 2.8 so I had to set the minimal TypeScript version to 3.0 in daacb43. Also this upgrade has allowed to implement a more simple and robust solution. I think this change is not critical because the version 3.0 is only 2 month younger than 2.8 and migrating from TypeScript 2 to 3 is not a big deal.
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor