Use common lineHash to share indice between text1 and text2 for correct line diffs #135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Use common cache of line contents between two texts in
DiffLinesToChars
to get line diffs correctly.Why?
In some cases, line diffs cannot be retrieved correctly in the standard way. The following code is one of the examples.
This fix corresponds to javascript implementation.
Testing?
Add a unit testcase
Anything Else?
This is my first contribution to this repository, therefore I would really appreciate any feedback, suggestions and change requests.