Added additional information about user on each schedule view: phone … #126
Conversation
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
======================================
Coverage 7.27% 7.27%
======================================
Files 22 22
Lines 522 522
======================================
Hits 38 38
Misses 484 484Continue to review full report at Codecov.
|
|
Thank you for your contribution! I'm planning to get some work in next week, will review this and get it merged as well. |
There was a problem hiding this comment.
This looks very good! I just have one ask - let's make this feature enabled via environment variable PAGERBEAUTY_LOAD_USER_CONTACT_METHODS=true.
The reason for this is I asked around and looks like this use-case is not very common. Some folks even insisted they want to avoid showing their phone number without a reason.
|
@sergiitk sure. will add a key for that |
# [1.1.0](v1.0.3...v1.1.0) (2020-01-25) ### Cleanup - [134](#134) **io** Limit information exposed though contact methods ### Features - [126](#126) **ui** Added optional user contact information to the schedule view
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What's this PR do?
In this PR I added an additional request for user contact methods. To display user phone on each schedule page. It would be useful for example for peoples who don't have access to PagerDuty, but they should see user phone for any emergency case.
How should this be manually tested?
On each schedule panel user, the phone should appear if user have at least one phone contact method
Example screenshot
What are the relevant tickets?
Fixes #125