[FEATURE core-oncalls] Removes implicit limit on how many on-calls can be loaded #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiitk
changed the title
sergiitk
changed the title
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
=========================================
- Coverage 3.75% 3.73% -0.03%
=========================================
Files 16 16
Lines 346 348 +2
Branches 47 48 +1
=========================================
Hits 13 13
- Misses 332 334 +2
Partials 1 1
Continue to review full report at Codecov.
|
sergiitk
changed the title
sergiitk
pushed a commit
that referenced
this pull request
Feb 7, 2019
# [1.0.0](v0.3.0...v1.0.0) (2019-02-07) ### Bug Fixes - [79](#79) **core** Fix error handling on unknown schedules - [80](#80) **ui-oncalls** Handle one user in the rotation (no end date) ### Cleanup - [75](#75) **chore-dependencies** Dependencies upgrade - [64](#64) **chore-dependencies** Dependencies upgrade - [83](#83) **chore-dependencies** Dependencies upgrade - [87](#87) **circleci** Move test key from secrets to allow exogenous PRs - [70](#70) **core** Load Schedules separately from OnCalls - [69](#69) **core** Move schedule loading out of web controller - [65](#65) **misc-local-dev** Acceptance tests in Docker - [62](#62) **misc-release** Automated Docker image builds with basic sanity checks - [71](#71) **misc-release** Improve Semantic Release - [66](#66) **misc-release** Run acceptance tests in CircleCI - [68](#68) **tests** Better test reports - [67](#67) **tests** Setup unit test tools and refactor acceptance tests ### Documentation - [78](#78) **deploy** Document deploying PagerBeauty to Heroku - [90](#90) **readme** Add PagerBeauty on Grafana Dashboard screenshot - [86](#86) **readme** Fix minor typo - [89](#89) **readme** Update Adding to Datadog dashboard gif - [85](#85) **readme** Update caps on Datadog ### Features - [73](#73) **core-incidents** Poll for active incidents - [72](#72) **core-oncalls** Removes implicit limit on how many on-calls can be loaded - [77](#77) **core-web** HTTP server can be started on custom port - [82](#82) **core-web** Support for Authentication Bearer access_token - [88](#88) **grafana** Support Grafana - [74](#74) **ui-oncalls** On-call active incident view: show incident info and make red
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
GET /oncallsis paginated and returns total(number escalation_policy of schedule x * schedule x) for each schedule x in all schedulesrecords, which is unpredictable and has a lot of data duplication.