Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constant time comparison should be used for verifying the MAC #12

Closed
alex opened this issue Nov 23, 2014 · 2 comments
Closed

Constant time comparison should be used for verifying the MAC #12

alex opened this issue Nov 23, 2014 · 2 comments

Comments

@alex
Copy link
Contributor

alex commented Nov 23, 2014

https://github.com/alexcrichton/cookie-rs/blob/master/src%2Fjar.rs#L297

Right now this uses a variable time comparison, potentially leaking data to an attacker, see http://codahale.com/a-lesson-in-timing-attacks/
@alexcrichton
Copy link
Collaborator

This is actually specifically using a constant time memory comparison from openssl, but thanks for the sharp eye!

@alex
Copy link
Contributor Author

alex commented Nov 23, 2014

Sorry about that! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alex @alexcrichton