Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please separate "secure" feature into a different crate #120

Closed
seanmonstar opened this issue May 2, 2019 · 3 comments
Closed

Please separate "secure" feature into a different crate #120

seanmonstar opened this issue May 2, 2019 · 3 comments

Comments

@seanmonstar
Copy link
Contributor

I realize its an optional feature, but even libraries that don't care care about signing cookies are still disrupted when breaking changes of ring are released (for example, seanmonstar/reqwest#517). If they were separate crates, the core Cookie API could be more stable, and then only cookie-secure (naming is hard) would ever need to update for new ring versions.

@ignatenkobrain
Copy link

For the Fedora, we would appreciate if we could get an option to use openssl or native-tls or whatsoever because we are not willing to package another crypto-library (ring). I don't have anything against code or person, but we just try to avoid yet another crypto libraries.

@newpavlov
Copy link

Considering that this crate no longer depends on ring, is it still an issue? (IIRC Fedora already packages some RustCrypto crates)

@SergioBenitez
Copy link
Member

I'm going to assume this is no longer issue since we no longer depend on ring; please correct me if I'm wrong!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants