Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error compiling against cookie crate 0.11.x #517

Closed
apiraino opened this issue May 2, 2019 · 3 comments
Closed

Error compiling against cookie crate 0.11.x #517

apiraino opened this issue May 2, 2019 · 3 comments
Labels
E-easy Effort: Easy! Start here :D E-pr-welcome The feature is welcome to be added, instruction should be found in the issue.

Comments

@apiraino
Copy link

apiraino commented May 2, 2019

Hello!

I'm not 100% sure about this, but ...

I think that now reqwest should update to the latest cookie crate (v0.12 as of yet) in order to fix an incompatibility with the ring crate.

I'm using the crate jsonwebtoken that depends on reqwest and this is what I get:

$ cargo check
    Updating crates.io index
error: failed to select a version for `ring`.
    ... required by package `jsonwebtoken v6.0.0`
    ... which is depended on by `open-taffeta v0.2.2 (...)`
versions that meet the requirements `^0.14.4` are: 0.14.6, 0.14.5, 0.14.4

the package `ring` links to the native library `ring-asm`, but it conflicts with a previous package which links to `ring-asm` as well:
package `ring v0.13.5`
    ... which is depended on by `cookie v0.11.1`
    ... which is depended on by `cookie_store v0.5.1`
    ... which is depended on by `reqwest v0.9.16`
    ... which is depended on by `open-taffeta v0.2.2 (...)`

If I am not mistaken, updating to cookie = 0.12 should solve the issue. Opinions?

Thanks!

@apiraino apiraino changed the title Error compiling againt cookie crate 0.11.x Error compiling against cookie crate 0.11.x May 2, 2019
@seanmonstar seanmonstar added the B-upstream Blocked: upstream. Depends on a dependency to make a change first. label May 2, 2019
@seanmonstar
Copy link
Owner

Sigh, this is exactly why I strongly feel the cookie crate should pull its secure feature into a separate crate, so those of us who just want cookies don't have to worry about updating ring.

I'll go poke cookie_store first...

@pfernie
Copy link
Contributor

pfernie commented May 2, 2019

cookie_store v0.6.0 has been published, updating the cookie dependency

@seanmonstar seanmonstar added E-easy Effort: Easy! Start here :D E-pr-welcome The feature is welcome to be added, instruction should be found in the issue. and removed B-upstream Blocked: upstream. Depends on a dependency to make a change first. labels May 2, 2019
repi added a commit to EmbarkStudios/reqwest that referenced this issue May 3, 2019
Fix seanmonstar#517 and use ring 0.14 instead of 0.13
@fenhl
Copy link

fenhl commented Sep 13, 2019

This issue has appeared again: rustls requires ring 0.16.5, cookie requires ring 0.14.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy Effort: Easy! Start here :D E-pr-welcome The feature is welcome to be added, instruction should be found in the issue.
Projects
None yet
Development

No branches or pull requests

4 participants