Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix examples not returning a Promise in actions #60

Merged
merged 1 commit into from Nov 19, 2021
Merged

Fix examples not returning a Promise in actions #60

merged 1 commit into from Nov 19, 2021

Conversation

juhanakristian
Copy link
Contributor

@juhanakristian juhanakristian commented Nov 19, 2021 •
edited

Fixes #55. The examples in docs (GoogleStrategy and GithubStrategy) and the LocalStrategy example in the readme had actions/loaders that were not returning a Promise.

sergiodxa
sergiodxa approved these changes Nov 19, 2021
View reviewed changes
Copy link
Owner

@sergiodxa sergiodxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sergiodxa sergiodxa added the dependencies Pull requests that update a dependency file label Nov 19, 2021
@sergiodxa sergiodxa merged commit 7c53615 into sergiodxa:main Nov 19, 2021
@zainfathoni zainfathoni mentioned this pull request Dec 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiodxa sergiodxa sergiodxa approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHubStrategy example crashes app
2 participants
@juhanakristian @sergiodxa