Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CSS Modules and manage styles with a custom css-in-js solution. #47

Merged
merged 3 commits into from
Dec 26, 2020

Conversation

sergiop
Copy link
Owner

@sergiop sergiop commented Dec 26, 2020

Closes #45

@codecov
Copy link

codecov bot commented Dec 26, 2020

Codecov Report

Merging #47 (6470752) into master (beca4f0) will decrease coverage by 3.12%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   98.19%   95.07%   -3.13%     
==========================================
  Files          13       21       +8     
  Lines         111      142      +31     
==========================================
+ Hits          109      135      +26     
- Misses          2        7       +5     
Impacted Files Coverage Δ
src/style/useStyle.js 68.75% <68.75%> (ø)
src/components/Alert/Alert.js 100.00% <100.00%> (ø)
src/components/Alert/alertStyles.js 100.00% <100.00%> (ø)
src/components/ImageItem/ImageItem.js 87.50% <100.00%> (+1.78%) ⬆️
src/components/ImageItem/imageItemStyles.js 100.00% <100.00%> (ø)
src/components/PoweredByGiphy/PoweredByGiphy.js 100.00% <100.00%> (ø)
.../components/PoweredByGiphy/poweredByGiphyStyles.js 100.00% <100.00%> (ø)
src/components/SearchForm/SearchForm.js 100.00% <100.00%> (ø)
src/components/SearchForm/searchFormStyles.js 100.00% <100.00%> (ø)
src/components/Spinner/Spinner.js 100.00% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beca4f0...6470752. Read the comment docs.

@sergiop sergiop merged commit ccf99a9 into master Dec 26, 2020
@sergiop sergiop deleted the feature/remove-css-modules branch December 26, 2020 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS Modules cannot be imported from within node_modules
1 participant