Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub workflows #357

Merged
merged 10 commits into from
Nov 27, 2022
Merged

GitHub workflows #357

merged 10 commits into from
Nov 27, 2022

Conversation

filipehb
Copy link
Contributor

@filipehb filipehb commented Oct 9, 2022 •
edited
Loading

Implements

  • New workflow to automatic publish new versions in Pypi
  • New workflow to run tests on new PR

Fixing

@serhatbolsu serhatbolsu marked this pull request as ready for review October 25, 2022 12:34
sadikkuzu
sadikkuzu suggested changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@sadikkuzu sadikkuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestions.

.github/workflows/publish.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
sadikkuzu
sadikkuzu reviewed Nov 2, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@sadikkuzu
Copy link
Contributor

Hi @filipehb
Can you merge latest serhatbolsu:master branch into your filipehb:github-workflows branch?
So, Makefile will be fixed and your ci workflow will work fine.

@serhatbolsu
Copy link
Owner

@filipehb <-

sadikkuzu
sadikkuzu approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@sadikkuzu sadikkuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done, thanks!
LGTM

@serhatbolsu
Copy link
Owner

remove the CI workflow if you like, there is little point of having it while tests are broken

@serhatbolsu
Copy link
Owner

@filipehb thank you

@serhatbolsu serhatbolsu merged commit 1d01ab7 into serhatbolsu:master Nov 27, 2022
@filipehb filipehb deleted the github-workflows branch November 29, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadikkuzu sadikkuzu sadikkuzu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@filipehb @sadikkuzu @serhatbolsu @filipehba