Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install setuptools on macos workflows #168

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thegecko
Copy link
Contributor

Macos workflows are currently broken because the hosts no longer have some key tools for some reason.

This PR fixes the build and test macos flows

@thegecko
Copy link
Contributor Author

thegecko commented Mar 2, 2024

Anything needed to chaperone this through?

@boneskull
Copy link
Contributor

boneskull commented Mar 13, 2024

I just ran into this. distutils was removed in Python v3.12

@thegecko
Copy link
Contributor Author

@reconbot can we expedite this?

@thegecko
Copy link
Contributor Author

bump

@Julusian
Copy link
Contributor

Julusian commented Jul 2, 2024

In one place 'macos-11' is used, in another 'macos-latest'.
Does this mean it will break when updating/changing the macos image? Perhaps the check should be done as runner.os == 'macOS' so that it doesn't care what image is used?

@thegecko
Copy link
Contributor Author

thegecko commented Jul 4, 2024

In one place 'macos-11' is used, in another 'macos-latest'.

Yeah, I don't know why this is. I'll try to converge on one and see if it still builds....

@Julusian
Copy link
Contributor

Julusian commented Jul 4, 2024

In one place 'macos-11' is used, in another 'macos-latest'.

Yeah, I don't know why this is. I'll try to converge on one and see if it still builds....

Part of why I asked this is because the macos-11 image is deprecated and being phased out https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories so that will need changing to macos-12 or something soon, which will also need updating on this check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants