Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A single changelog #1847

Open
reconbot opened this issue Apr 27, 2019 · 6 comments
Open

A single changelog #1847

reconbot opened this issue Apr 27, 2019 · 6 comments
Labels
feature-request Feature or Enhancement internal chores etc needs-testing

Comments

@reconbot
Copy link
Member

💥 Proposal

What feature you'd like to see

I'd like to see a single global changelog for the project.

Motivation

The current changelogs aren't very helpful for understanding what changed when you upgrade. Dependent packages just say "version bump".

Pitch

Figure out how lerna generates these and see if it's got a better option.

@reconbot reconbot added the feature-request Feature or Enhancement label May 2, 2019
@tkurki
Copy link

tkurki commented Jun 8, 2020

https://github.com/lerna/lerna-changelog apparently works on labeled PRs, so it would be a good idea to start labeling PRs so that eventually it will have something to chew on. And labels would be useful for hu-mans also.

The default labels are

  • breaking (💥 Breaking Change)
  • enhancement (🚀 Enhancement)
  • bug (🐛 Bug Fix)
  • documentation (📝 Documentation)
  • internal (🏠 Internal)

@GazHank
Copy link
Contributor

GazHank commented Jul 10, 2021

Hi @tkurki if we add these as labels, would I be correct to assume that this would just work going forward? That is to say reclassifying previous PRs wouldn't really help us?

@tkurki
Copy link

tkurki commented Jul 19, 2021

Sorry, I have not looked into how this project creates releases and I don't know if you can update just the notes for existing Github releases.

I just think it would make sense to

  • pick a tool for generating release notes from commits or PRs
  • start applying the mechanism (naming, GH labels, etc) that the tool uses
  • add release notes generation to the release process

@GazHank GazHank added the internal chores etc label Jul 19, 2021
@GazHank
Copy link
Contributor

GazHank commented Jul 19, 2021

I've added a couple of labels we can use in the future (breaking, and internal) for the others I think we should be able to map existing labels within the package.json:

{
  // ...
  "changelog": {
    "labels": {
      "breaking": ":boom: Breaking Change",
      "feature-request": ":rocket: Enhancement",
      "bug": ":bug: Bug Fix",
      "docs": ":memo: Documentation",
      "internal": ":house: Internal"
    }
  }
}

@GazHank
Copy link
Contributor

GazHank commented Jul 19, 2021

A few observations so far while trying this:

  • We will probably need to reclassify some PRs, this items is a good example, while adding this could be considered an enhancement, for most users this would probably just be an internal change
  • we will need to see how well the lerna change log works with the overall package structure (Doesn't work well with independent mode lerna/lerna-changelog#26)
  • While it seems to work for unreleased info (so could be used just before publication), the historic functioanlity doesnt seem to work (for me)

@GazHank
Copy link
Contributor

GazHank commented Jul 19, 2021

I've drafted #2298 for now

I've kept this pretty close to the current change log, and we can drop the commiters info if we like (https://github.com/lerna/lerna-changelog#configuration) .

Based on this initial config at the moment it generates:

Unreleased (2021-07-19)

Chores

Committers: 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Feature or Enhancement internal chores etc needs-testing
Development

No branches or pull requests

3 participants