Stop bundling node-pre-gyp to allow for upgrades #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The latest and greatest recommendation from node-pregyp - Stops issues when people have different node-pre-gyp’s installed already
|
I also tested this as a dependency of another project via the github/project#branch source method and had no issues. |
| @@ -87,6 +83,7 @@ | |||
| }, | |||
| "license": "MIT", | |||
| "scripts": { | |||
| "preinstall": "npm install node-pre-gyp node-pre-gyp-github", | |||
| "install": "node-pre-gyp install --fallback-to-build", | |||
| "rebuild": "npm rebuild && node-pre-gyp rebuild", | |||
There was a problem hiding this comment.
I'm curious: why are you overriding rebuild that way?
reconbot
added a commit
that referenced
this pull request
Jul 24, 2018
- The latest and greatest recommendation from node-pre-gyp - Stops issues when people have different node-pre-gyp’s installed already
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #753