New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to nix-0.28 #176
base: main
Are you sure you want to change the base?
Update to nix-0.28 #176
Conversation
While at it, use std::os::fd::owned::OwnedFd instead of custom implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work!
Could you look into the CI failures?
Also, could you add an entry to the changelog about this?
Hi. This looks like a MSRV issue. |
Hmm, this does not seem MSRV-related to me, though. Here is a run with 1.76.0: The MSRV is set to 1.59.0, where have you found the 1.36.0 reference? |
You're right. I was looking at the first issues like here: https://github.com/serialport/serialport-rs/actions/runs/8535157043/job/23396025571?pr=176#step:7:32.
|
Both variants provide a direct conversion from Duration, so there is no need for us to deal with converting the timeout and signedness.
No, this looks like an issue with the signedness of Ended up with bf7050c while looking into this. So there is just raising the MSRV left.
At a first glance at least when it comes to the Rust support shipped with Yocto. Dependents using older Yocto releases could still pin their dependency on us to a minor version and we could attempt to scan all publicly visible dependencies. And on the other hand there is also meta-rust-bin which provides the brand spanking new releases of Rust. Let me think and sleep over it. |
While at it, use std::os::fd::owned::OwnedFd instead of custom implementation.
Fixes #175