Skip to content

Commit

Permalink
fix(travis): don't run SauceLabs tests on PR's
Browse files Browse the repository at this point in the history
The fix from #32 made it so that the build always passes, which wasn’t
the idea. This was happened on #33 which triggered two Travis builds:
one as PR which didn’t run SL so it passed, and another as a regular
Push that had failing SL tests (IE8 and trailing commas ftw) but still
passed.

So the conditional is greatly simplified. If it’s a PR just pass it,
otherwise run the SL tests. Don’t know why the Travis docs had such a
backwards workaround sample.

Fixes #31
  • Loading branch information
seriema committed Sep 13, 2015
1 parent 5cecae0 commit 0e07eb3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ before_script:
script:
- 'npm test'
- 'npm run coveralls'
- '[ "${TRAVIS_PULL_REQUEST}" = "false" ] && npm run saucelabs || true'
- '[ "${TRAVIS_PULL_REQUEST}" = "true" ] || npm run saucelabs'
after_script:
- 'cat $LOGS_DIR/karma.log'
env:
Expand Down

0 comments on commit 0e07eb3

Please sign in to comment.