Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SauceLabs failure on Travis builds #32

Merged
merged 1 commit into from
Sep 13, 2015
Merged

Fix SauceLabs failure on Travis builds #32

merged 1 commit into from
Sep 13, 2015

Conversation

MartinSandstrom
Copy link
Contributor

Fixes #31

@seriema
Copy link
Owner

seriema commented Sep 13, 2015

Gah... their workaround sample said || false which means it'll fail the build. Not really what I'd expect. Try true instead. Bonus if you do a git amend.

seriema added a commit that referenced this pull request Sep 13, 2015
@seriema
Merge pull request #32 from MartinSandstrom/patch-1
5cecae0 
fix(travis): don't run SauceLabs on PR's
@seriema seriema merged commit 5cecae0 into seriema:master Sep 13, 2015
@seriema
Copy link
Owner

seriema commented Sep 13, 2015

Perfect, thanks!

seriema added a commit that referenced this pull request Sep 13, 2015
@seriema
fix(travis): don't run SauceLabs tests on PR's
0e07eb3 
The fix from #32 made it so that the build always passes, which wasn’t
the idea. This was happened on #33 which triggered two Travis builds:
one as PR which didn’t run SL so it passed, and another as a regular
Push that had failing SL tests (IE8 and trailing commas ftw) but still
passed.

So the conditional is greatly simplified. If it’s a PR just pass it,
otherwise run the SL tests. Don’t know why the Travis docs had such a
backwards workaround sample.

Fixes #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MartinSandstrom @seriema