fix(apimock): normalize file paths for empty query params

Empty/undefined query param values won’t be included in the mock data file path. They were inconsistent anyway. Fixes #48
seriema · Oct 18, 2015 · 9252f71 · 9252f71
1 parent 3a1ac50
commit 9252f71
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/app/scripts/angular-apimock.js b/app/scripts/angular-apimock.js
@@ -135,6 +135,8 @@ angular.module('apiMock', [])
 						key +
 						(topLevel ? '' : ']'));
 					});
+				} else if (toSerialize === undefined || toSerialize === '') {
+					parts.push(encodeUriQuery(prefix));
 				} else {
 					parts.push(encodeUriQuery(prefix) + '=' + encodeUriQuery(serializeValue(toSerialize)));
 				}

diff --git a/test/spec/services/angular-apimock.js b/test/spec/services/angular-apimock.js
@@ -730,7 +730,7 @@ describe('Service: apiMock', function () {
 
 				it('should handle empty value', function () {
 					defaultRequest.url = '/api/pokemon?releaseDate';
-					defaultExpectPath = '/mock_data/pokemon/releasedate=.get.json';
+					defaultExpectPath = '/mock_data/pokemon/releasedate.get.json';
 
 					expectHttpSuccess();
 				});
@@ -740,7 +740,7 @@ describe('Service: apiMock', function () {
 					defaultRequest.params = {
 						'releaseDate': undefined
 					};
-					defaultExpectPath = '/mock_data/pokemon/releasedate=undefined.get.json';
+					defaultExpectPath = '/mock_data/pokemon/releasedate.get.json';
 
 					expectHttpSuccess();
 				});