Skip to content

Commit

Permalink
fix(npm): npm install was failing because it ran bower as `postinst…
Browse files Browse the repository at this point in the history
…all`

It’s only interesting to run when developing the library. Added it as a
note in CONTRIBUTING.md.
  • Loading branch information
seriema committed Oct 25, 2015
1 parent c6dd78c commit a696e14
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Helpful steps:
1. One PR per logged bug or feature (read above about **Bugs** or **Features**)
2. Check for an existing issue or create a new one (see step 1)
3. Fork the project and create a new branch to do your changes in
4. Install dependencies with `npm install` (you'll need [Node](https://nodejs.org), [Grunt](http://gruntjs.com), and [Bower](http://bower.io) already installed)
4. Install dependencies with `npm install` and `bower install` (you'll need [Node](https://nodejs.org), [Grunt](http://gruntjs.com), and [Bower](http://bower.io) already installed)
5. Run `grunt` before every commit and see the **Commit guidelines** section below
6. Create a PR and reference the issue from step 2

Expand Down
4 changes: 2 additions & 2 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ module.exports = function (grunt) {
// Project settings
yeoman: {
// configurable paths
version: require('./bower.json').version,
app: require('./bower.json').appPath,
version: require('./package.json').version,
app: 'app',
dist: 'dist',
test: 'test'
},
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@
"node": ">=0.12.0"
},
"scripts": {
"postinstall": "bower install",
"test": "grunt test",
"debug": "./node_modules/.bin/karma start karma.conf.js --browsers=Chrome --debug --autoWatch=true",
"saucelabs": "grunt karma:sauce",
Expand Down

0 comments on commit a696e14

Please sign in to comment.