Add TravisCI for validating the mount between VM and RPi #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accept a second parameter to override the docker repo name.
The main reason is because it allows running docker containers in privileged mode. That allows the VM to be mounted on the containerized RPi. That mount is the connection between the user's RPi and Retro-Cloud, so I needed a way to have that connection tested continously to confidentely build new features. CircleCI doesn't privileged containers, so I will be moving away from it eventually.
Similar to the one in VM. Downloads Elite for multiple platforms. Only NES and Spectrum were detected by EmulationStation or started.
So the user can copy all their ROMs as a separate manual step because it will only work if: * mounting the VM worked * the user has ROMs in ~/RetroPie/roms The user should be ready for a long wait if they have a lot of ROMs.
This is only possible on Travis. CircleCI is left unchanged so there is a baseline to compare with.
Exactly like the CircleCI one. Useful for making sure that every individual commit works, and not just the last commit.
|
The failed build is the Docker build. I've locked down the RetroPie version, but the emulators aren't possible to lock down, so they've grown apart and don't build together anymore. I'll work on the Dockerfile separately from this PR, as the existing image works fine. |
seriema
commented
Jun 21, 2020
| @@ -0,0 +1,50 @@ | |||
| gameplan | |||
There was a problem hiding this comment.
This file wasn't meant to be here. The auto-staging feature in Git Kraken when switching branches is really annoying...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing TravisCI against CircleCI
Pros
amdarchitecture, although it'samd64and notamd32v7like the RaspberryPi so it's not really useful.Cons
Summary
Using TravisCI
This PR adds Travis (e54ee00), as well as a "copy ROMs from RPi to File Share" script (f44195c) to showcase how Travis is able to mount the VM in the RPi container and validate scenarios like that. This will be fundamental for the coming features.
TODO's