-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update target framework to netstandard2.0 #67
Conversation
Nice work @Bertk ! Does anyone knows when/if this PR would merge and when do we expect to have a new version for the package? |
I can merge but I cannot test it though |
src/Serilog.Sinks.AzureTableStorage/Serilog.Sinks.AzureTableStorage.csproj
Show resolved
Hide resolved
...eTableStorageWithProperties.Tests/Serilog.Sinks.AzureTableStorageWithProperties.Tests.csproj
Outdated
Show resolved
Hide resolved
...ilog.Sinks.AzureTableStorage/LoggerConfigurationAzureTableStorageWithPropertiesExtensions.cs
Outdated
Show resolved
Hide resolved
...ilog.Sinks.AzureTableStorage/LoggerConfigurationAzureTableStorageWithPropertiesExtensions.cs
Outdated
Show resolved
Hide resolved
@kashifsoofi Please check the support matrix before I will resolve the comments. I feel using .NET standard 2.0 as the only target framework is a valid and good decision.
see also: |
Fair enough, but lets update test project to test both net72 and dotnetcore 3.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
I do not know what happened during release of V5.0. #75 The release package in nuget.org still references WindowsAzure.Storage and not Microsoft.Azure.Cosmos.Table. The target framework is also not netstandard2.0 . |
#65 #60 #34