Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update target framework to netstandard2.0 #67

Merged
merged 6 commits into from
Jun 25, 2020
Merged

update target framework to netstandard2.0 #67

merged 6 commits into from
Jun 25, 2020

Conversation

Bertk
Copy link
Contributor

@Bertk Bertk commented Apr 1, 2020

@tdraganidis
Copy link

Nice work @Bertk ! Does anyone knows when/if this PR would merge and when do we expect to have a new version for the package?

@kashifsoofi
Copy link
Contributor

I can merge but I cannot test it though

@kashifsoofi kashifsoofi self-requested a review June 22, 2020 11:26
@Bertk
Copy link
Contributor Author

Bertk commented Jun 22, 2020

@kashifsoofi Please check the support matrix before I will resolve the comments. I feel using .NET standard 2.0 as the only target framework is a valid and good decision.

  • .NET standard 2.0 is supported by .NET framework 4.7.1 (better 4.7.2) and later without additional dependencies
  • .NET framework 4.5 supported ended 10/9/2012 (extended support ended 1/12/2016)
  • .NET standard 2.1 is not supported by any .NET framework version
  • nuget package Microsoft.Azure.Cosmos.Table V1.0.7 supports only .NET standard 2.0

see also:
https://support.microsoft.com/en-us/lifecycle/search?alpha=.NET%20Framework
dotnet/standard#514

@kashifsoofi
Copy link
Contributor

@kashifsoofi Please check the support matrix before I will resolve the comments. I feel using .NET standard 2.0 as the only target framework is a valid and good decision.

* **.NET standard 2.0** is supported by .NET framework 4.7.1 (better **4.7.2**) and later without additional dependencies

* **.NET framework 4.5** supported ended **10/9/2012**  (extended support ended **1/12/2016**)

* **.NET standard 2.1** is not supported by any .NET framework version

* nuget package **Microsoft.Azure.Cosmos.Table V1.0.7** supports only **.NET standard 2.0**

see also:
https://support.microsoft.com/en-us/lifecycle/search?alpha=.NET%20Framework
dotnet/standard#514

Fair enough, but lets update test project to test both net72 and dotnetcore 3.1

Copy link
Contributor

@kashifsoofi kashifsoofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kashifsoofi kashifsoofi merged commit b9b32e8 into serilog-contrib:dev Jun 25, 2020
@Bertk Bertk deleted the standard branch June 25, 2020 21:15
@Bertk Bertk restored the standard branch April 28, 2021 08:41
@Bertk
Copy link
Contributor Author

Bertk commented Apr 28, 2021

I do not know what happened during release of V5.0. #75

The release package in nuget.org still references WindowsAzure.Storage and not Microsoft.Azure.Cosmos.Table. The target framework is also not netstandard2.0 .
nuget-Serilog Sinks AzureTableStorage

@Bertk Bertk mentioned this pull request Apr 28, 2021
@Bertk Bertk deleted the standard branch January 24, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants