Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

Get rid of 'deprecated' warnings in Elastic 5.6.2 #142

Merged
merged 7 commits into from
Jan 18, 2018

Conversation

VanHuychemG
Copy link
Contributor

Our Elastic 5.6.2 logs are flooded with below errors:
The [string] field is deprecated, please use [text] or [keyword]
[omit_norms] is deprecated, please use [norms] instead with the opposite boolean value

Updated the schema following https://www.elastic.co/blog/strings-are-dead-long-live-strings

Our Elastic 5.6.2 logs are flooded with below errors:
The [string] field is deprecated, please use [text] or [keyword]
[omit_norms] is deprecated, please use [norms] instead with the opposite boolean value

Updated the schema following https://www.elastic.co/blog/strings-are-dead-long-live-strings
@CumpsD
Copy link

CumpsD commented Jan 6, 2018

Looking forward to this, we are seeing the same

@CumpsD
Copy link

CumpsD commented Jan 7, 2018

When reading the issues, it seems in ES 6 the deprecation turned into removal, so this PR might fix ES 6 support too :)

@quetzalcoatl
Copy link

LGTM - but I'm no expert here :) Changes are similar to what I did to patch up the same set of issues for me (see code I provided in comments in issue #129). However, I didn't know about keyword type (sadly, I didn't stumble on that strings-are-dead article) so I had to comment out 'ignore_above' as well. Good to know! This piece is obviously much better than mine.

One thing I noticed is that this is just a change to mappings. Since newest ElasticSearch changed the schema (like 'index' is now true/false), then IMHO applying this will break support for lower versions of ElasticSearch. That may be OK, but then, at least one person was concerned some time ago

@VanHuychemG
Copy link
Contributor Author

I'll have a go at creating some kind of template provider, that can be set from the options ,something like pre-version5, version5, version6.

@CumpsD
Copy link

CumpsD commented Jan 11, 2018

Awesome! Looking forward to get this merged! // @mivano

@mivano
Copy link
Contributor

mivano commented Jan 11, 2018 via email

@mivano mivano merged commit 4d2425b into serilog-contrib:dev Jan 18, 2018
@mivano
Copy link
Contributor

mivano commented Jan 18, 2018

Great addition and thanks for the backward capability option!

@CumpsD
Copy link

CumpsD commented Jan 18, 2018

Awesome!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants