Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

add .netstandard2.0 target #222

Merged
merged 2 commits into from
Mar 15, 2019
Merged

add .netstandard2.0 target #222

merged 2 commits into from
Mar 15, 2019

Conversation

vhatsura
Copy link

@vhatsura vhatsura commented Mar 13, 2019 •
edited

to fix #210 and fix #196

A few comments about changes:

  • DOTNETCORE constant is used only in tests projects. By this reason it was removed from Serilog.Formatting.Elasticsearch and Serilog.Sinks.Elasticsearch projects
  • NO_SERIALIZATION and NO_TIMER constants are not used in Serilog.Sinks.Elasticsearch project and was removed from netstandard1.3 target framework
  • System.Exception.GetObjectData is accessible in netstandard2.0, however ExceptionMethod is initialized with null value. So, there was introduced new compilation constant PARTIALLY_SERIALIZATION to handle such situation for netstandard2.0

@mivano mivano merged commit 52411d4 into serilog-contrib:dev Mar 15, 2019
@mivano
Copy link
Contributor

mivano commented Mar 15, 2019

Thanks!

@vhatsura vhatsura deleted the formatter/netstandard2.0 branch March 15, 2019 22:59
@ffMathy ffMathy mentioned this pull request May 1, 2019
Closed
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add .Net Standard 2.0 target when logging an exception the "ClassName" property remains empty
2 participants
@vhatsura @mivano