This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
Adding aliases when creating index. #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aliases are required for assigning rollover jobs to indexes.
|
Omitted to update template_v7.json in Tests |
mivano
reviewed
Nov 8, 2019
mivano
reviewed
Nov 8, 2019
mivano
reviewed
Nov 8, 2019
src/Serilog.Sinks.Elasticsearch/LoggerConfigurationElasticSearchExtensions.cs
Outdated
Show resolved
Hide resolved
mivano
reviewed
Nov 8, 2019
src/Serilog.Sinks.Elasticsearch/Sinks/ElasticSearch/ElasticsearchSinkOptions.cs
Outdated
Show resolved
Hide resolved
mivano
reviewed
Nov 8, 2019
test/Serilog.Sinks.Elasticsearch.Tests/Templating/template_v7.json
Outdated
Show resolved
Hide resolved
|
Thanks for the PR. I added some small comments. |
Changed Sample project program.cs back to original version
…xtensions.Elasticsearch not to change signature. (Caused breaking change)
Added one index alias in template tests for ES7. (Accordingly changed template_v7.json
|
Thanks for the changes, sorry that it took some time to merge. A pre-release package will be created, please see if this suites your needs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addreses issue #289
It does not introduce breaking change.
Adding aliases when creating index.
Changes in Serilog.Sinks.Elasticsearch