This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
Upgrade Elasticsearch.Net to 7.8.1 #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packages were renamed to Elastic.Elasticsearch.*. Old versions were removed from the Elastic Abstractions CI feed. Part of #340 fix.
8 tasks
|
Thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
Issue #340.
Does this PR introduce a breaking change?
None in Serilog.Sinks.Elasticsearch.
There were a few breaking changes in Elasticsearch.Net between v7.0.0–v7.8.1 but the sink is not affected by them as far as I could tell and test.
Please check if the PR fulfills these requirements
Other information:
I had to introduce two extra changes for the upgrade:
Microsoft.CSharpv4.5.0 → v4.6.0 because it was upgraded in Elasticsearch.Net as well.Elastic.ManagedandElastic.Xunitpackages in the integration tests with the newerElastic.Elasticsearch.ManagedandElastic.Elasticsearch.Xunit. The old packages were deleted from the Elastic Abstractions CI feed and not available anymore.I ran the existing unit and integration tests (ES v6.0 and v7.8) on net461 (mono 6.10.0) and netcoreapp 2.1. I was not able to test on Windows since I don't have one atm. Hopefully, they will pass in CI on Windows 🙏