Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

Issue nr: 14594 - removing old implementation where fields where dot-… #351

Merged
merged 2 commits into from
Sep 16, 2020
Merged

Conversation

rajmondburgaj
Copy link
Contributor

@rajmondburgaj rajmondburgaj commented Jul 30, 2020

…escaped due to old ELK not supporting it. But now this is supported, therefore there is no need to escape it anylonger.

What issue does this PR address?

Disable dot escaping for field names, as it is supported since long time ago in ELK.

Does this PR introduce a breaking change?

If the field name x.y was used, till now in kibana it would show as x/y, after this commit, it will show as x.y. But I think the breaking change is very small.

Please check if the PR fulfills these requirements

  • The commit follows our guidelines
  • Unit Tests for the changes have been added (for bug fixes / features)

There was no need for new unit tests, since only old code was removed.

Other information:

Also changed a method from using recursion to a simple while loop.

…escaped due to old ELK not supporting it. But now this is supported, therefore there is no need to escape it anylonger.
@mivano mivano merged commit 988a4ee into serilog-contrib:dev Sep 16, 2020
@mivano
Copy link
Contributor

mivano commented Sep 16, 2020

Thanks for the PR and sorry for not responding sooner!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants