Add options to provide a custom template and overwrite an existing #51
Conversation
|
Anything I can do to help get these changes, or something like them, integrated in? I've hacked around with my project to get this sort of functionality in, but I think it would make sense to have it in the sink. Are there oppositions to the changes I made, or something that I just screwed up on? Thanks! |
|
Hi @blachniet, I'm not an active maintainer of this sink but I notice your initial PR commit was non-mergeable and so CI failed. Merging upstream/dev back into your PR branch should kick off a new build. Hope this helps, |
|
Cool! Can you also add some details to the readme.md file? |
| /// When using the <see cref="AutoRegisterTemplate"/> feature, this allows you to override the default template content. | ||
| /// If not provided, a default template that is optimized to deal with Serilog events is used. | ||
| /// </summary> | ||
| public Func<string> GetTemplateContent { get; set; } |
There was a problem hiding this comment.
It might be more useful to return object here, the implementer could return a string or anonymous object in that case.
# Conflicts: # src/Serilog.Sinks.Elasticsearch/Sinks/ElasticSearch/ElasticsearchSinkState.cs # test/Serilog.Sinks.Elasticsearch.Tests/Serilog.Sinks.Elasticsearch.Tests.csproj
|
I made some of the suggested changes:
I noticed that most of the code examples and feature details are described in wiki pages as opposed to the README. Should I add a code example there, with a link to it from the README, after it's merged in? Or should I add all that to the README? Thanks! |
|
Thanks @blachniet for the PR! I merged it now to dev and will create a merge to master soon to create new packages. Regarding the wiki; I notice that I rather maintain the readme file then the wiki but they need to be in sync somehow. I will update it when it is merged to master. |
These changes allow the user to supply a custom template and overwrite the template if it already exists in Elasticsearch.
GetTemplateContentcan be set to return the body of the PUT template HTTP request. This allows users to further customize the Elasticsearch template, instead of using the standard Serilog template.If
OverwriteTemplateis set to true, the state class will not check to see if the template already exists before PUT-ing the new one, which will overwrite the template if it already exists.