Skip to content

Commit

Permalink
Set configured sentry logger in all cases.
Browse files Browse the repository at this point in the history
This fixes a bug in my previous PR where the logger is not getting set in both branches of if/else block in the SentrySink class.
  • Loading branch information
Max Lancaster committed Nov 16, 2018
1 parent 7f7732a commit cb7a03b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<Description>A Sentry sink for Serilog</Description>
<VersionPrefix>2.4.0</VersionPrefix>
<VersionPrefix>2.5.0</VersionPrefix>
<Authors>Oleg Shevchenko</Authors>
<TargetFrameworks>net451;netstandard2.0</TargetFrameworks>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
Expand Down
2 changes: 1 addition & 1 deletion src/Serilog.Sinks.Sentry/SentrySink.cs
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ public void Emit(LogEvent logEvent)
_sentryRequestFactory ?? new SentryRequestFactory(httpContext),
_sentryUserFactory ?? new SentryUserFactory(httpContext))
{
Logger = _logger,
Release = _release,
Environment = _environment
};
Expand All @@ -115,6 +114,7 @@ public void Emit(LogEvent logEvent)
};
}

ravenClient.Logger = _logger;
ravenClient.LogScrubber = _dataScrubber;
ravenClient.Capture(sentryEvent);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Serilog.Sinks.Sentry/Serilog.Sinks.Sentry.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<Description>A Sentry sink for Serilog</Description>
<VersionPrefix>2.4.0</VersionPrefix>
<VersionPrefix>2.5.0</VersionPrefix>
<Authors>Oleg Shevchenko</Authors>
<TargetFrameworks>net45;netstandard2.0</TargetFrameworks>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
Expand Down

0 comments on commit cb7a03b

Please sign in to comment.