Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#99): replace xml formatting, prevent double format #102

Merged

Conversation

followynne
Copy link
Member

This PR fixes #99. It

  • pretty-prints XML only on first modal opening
  • replaces custom XML formatting with external library

@followynne followynne enabled auto-merge (squash) January 3, 2024 22:24
@followynne followynne merged commit 012dd73 into serilog-contrib:master Jan 4, 2024
4 checks passed
@mo-esmp
Copy link
Member

mo-esmp commented Jan 4, 2024

@followynne After reviewing and merging PRs 95 and 98, would you like to publish the nuget package yourself?

@followynne
Copy link
Member Author

@mo-esmp

That's fine, as you like 😊
If you want, I could try fixing the datetime rendering issue and publish a nuget beta with the latest changes, to let users test it and do a first nuget publish?

@mo-esmp
Copy link
Member

mo-esmp commented Jan 4, 2024

It sounds good to me. Let's publish a beta version first and thanks again for your effort.

@followynne
Copy link
Member Author

Awesome! Thanks a lot to you 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants