use TryAddSigleton to prevent service override in clients #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 😄
This PR would like to review the IMongoClient Singleton Registration.
When a client uses the MongoDB provider, probably the IMongoClient it's already registered as a singleton (as recommended by the official SDK docs).
By using TryAddSingleton, serilog-ui will register the class only if the client didn't already do it.
It won't override anymore a custom IMongoClient singleton implementation added before AddSerilogUi(...) in ConfigureServices.
Let me know if there's anything unclear or wrong with this change!