-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve date management and manipulation #34
Improve date management and manipulation #34
Conversation
Thanks for the PR. Other data providers should be checked and need to find a way to add integration tests against databases to avoid manual testing every time. |
You're right, I went straight with a fix for Mongo as it's the provider I currently use and I noticed it early 😊 SQL-like should be fine, from the table structure, probably Elastic-provider should be double checked (it can be done in a separate pr). On Integration tests, I have it on my todo: create the test env and then start adding some integration for Mongo (already been there, already did them) 😁 don't have an ETA but I'll do that 😊 |
Hi @mo-esmp, sorry for the late, I aligned the branch to master and checked ElasticSearch date search result - from my check it works fine, thus if you want to merge the PR it should be all clear (SQL should be already good) 😄 (tests will go on a separate branch) |
Hey @followynne, Thanks again to double check, for the weekend I will have time to check the PR and sorry for delay. |
55c81f5
to
0baeeea
Compare
Is this PR still relevant? |
0baeeea
to
b699014
Compare
Yes - if I remember correctly, it was a small fix to improve timezone management with MongoDb 2 datetime fields 😃 (I also added the test fix for Mongodb package 2.19, if you have time to re-try them...) |
Hi @mo-esmp,
this PR aims to improve the date-time management in the serilog-ui middleware.