Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve date management and manipulation #34

Merged
merged 4 commits into from
Mar 12, 2023

Conversation

followynne
Copy link
Member

Hi @mo-esmp,

this PR aims to improve the date-time management in the serilog-ui middleware.

  • removed in the middleware the endDate manipulation, as the UI now has selectable date & time
  • identify the parsed dates as Local (based on the input received from the UI)
  • updated MongoDbDataProvider to use UtcTimeStamp, since the TimeStamp provider is empty until model normalization
  • (chore) remove npm i target from Serilog.Ui.Web, due to VS issues with locking files. The packages installation will be issued manually by the dev on the first run 👍

@followynne followynne changed the title Fix/UI date management Improve date management and manipulation May 28, 2022
@mo-esmp
Copy link
Member

mo-esmp commented May 29, 2022

Thanks for the PR. Other data providers should be checked and need to find a way to add integration tests against databases to avoid manual testing every time.

@followynne
Copy link
Member Author

You're right, I went straight with a fix for Mongo as it's the provider I currently use and I noticed it early 😊 SQL-like should be fine, from the table structure, probably Elastic-provider should be double checked (it can be done in a separate pr).

On Integration tests, I have it on my todo: create the test env and then start adding some integration for Mongo (already been there, already did them) 😁 don't have an ETA but I'll do that 😊

@followynne
Copy link
Member Author

Hi @mo-esmp,

sorry for the late, I aligned the branch to master and checked ElasticSearch date search result - from my check it works fine, thus if you want to merge the PR it should be all clear (SQL should be already good) 😄

(tests will go on a separate branch)

@followynne followynne changed the base branch from dev to master August 16, 2022 21:41
@mo-esmp
Copy link
Member

mo-esmp commented Aug 16, 2022

Hey @followynne, Thanks again to double check, for the weekend I will have time to check the PR and sorry for delay.

@mo-esmp
Copy link
Member

mo-esmp commented Mar 12, 2023

Is this PR still relevant?

@followynne
Copy link
Member Author

Is this PR still relevant?

Yes - if I remember correctly, it was a small fix to improve timezone management with MongoDb 2 datetime fields 😃
I'd merge it, if you're okay with it!

(I also added the test fix for Mongodb package 2.19, if you have time to re-try them...)

@followynne followynne requested a review from mo-esmp March 12, 2023 22:49
@mo-esmp mo-esmp merged commit b4038f4 into serilog-contrib:dev Mar 12, 2023
@followynne followynne deleted the fix/ui-date-management branch March 13, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants