Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing dashboard authorization filter. #63

Merged
merged 9 commits into from
Mar 13, 2023
Merged

Conversation

mo-esmp
Copy link
Member

@mo-esmp mo-esmp commented Mar 2, 2023

Unifying authentication and authorization mechanism like the Hangfire dashboard!

@mo-esmp mo-esmp requested a review from followynne March 2, 2023 13:46
@followynne
Copy link
Member

Hey @mo-esmp,

Love the idea of going with the Hangfire authorization style! 🤗 I'm not sure when but I'll try to read and review the PR as soon as possible 😉

(fyi, I'm going onwards with the integration test pr - I just need to complete elastic ones and a small mongo-test refactor to merge that part. I'll write you about it when I complete it 😄)

Copy link
Contributor

@sommmen sommmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@followynne followynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mo-esmp

I reviewed the PR - IMHO, it's a great feature, all green from me! In the feature we could think if it can be useful to add any auth related to policies/etc, right now I'd merge it ASAP 😄

A quick suggestion: I made a small cleanup branch on the tests naming etc here https://github.com/followynne/serilog-ui/tree/chore/ui-web-cleanup, give it a look if you think it's good to include on your branch 😃

A quick notice, on test "Local_Request_are_allowed_by_default": I saw it fails if the front end build wasn't run before launching it- in the future I'll try to see if there's a way to prevent this 😃

@followynne
Copy link
Member

(@mo-esmp I already approved the PR as per prev comment)

@mo-esmp
Copy link
Member Author

mo-esmp commented Mar 13, 2023

@followynne Please send your PR to this one, setup-ci branch needs more work. I need to figure out how run tests that need Docker in GitHub environment. Before sending the PR, please rename Util to Utility. Let's have this convention to use the full name instead of an abbreviation (choosing Implementation over Impl).

@followynne
Copy link
Member

@mo-esmp yep, all good 🛩️
I opened #67 to merge the chore on this branch (then you can merge it), let me know if anything else 😃

chore(auth-tests): create application factory util, rename files
@mo-esmp mo-esmp merged commit 2ee1c80 into dev Mar 13, 2023
@mo-esmp mo-esmp deleted the feature/dashboard-auth branch March 13, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants