Release 6.0.0 #430
Merged
Release 6.0.0 #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation * Fixes vulnerablities found in #417 * Microsoft.Azure.Services.AppAuthentication is obsolete. SqlClient was updated to version 3.0.0 which has integrated AD authentication capablities which can be configured in the connection string (https://learn.microsoft.com/en-us/sql/connect/ado-net/sql/azure-active-directory-authentication?view=sql-server-ver16). * Removed sink options UseAzureManagedIdentity, AzureServiceTokenProviderResource, AzureTenantId and any related code.
…y with other sinks
Error:
Testhost process exited with error: Error:
An assembly specified in the application dependencies manifest (Serilog.Sinks.MSSqlServer.Tests.deps.json) was not found:
package: 'Azure.Core', version: '1.6.0'
path: 'lib/netstandard2.0/Azure.Core.dll'
. Please check the diagnostic logs for more information.
Solution found here: https://stackoverflow.com/a/73548949/2586938
* Updated most nugets to the latest version (except SqlClient). * Removed obsolete System.Configuration extension methods. They were only used in .NET Framework 4.5.2 which is not supported anymore. * Simplified and consolidated frameworrk conditions in csproj files
Breaking change: "Encrypt=False" must now be explicitly set in connection string if no encryption should be used. Otherwise an SqlException will occurr. Details: https://github.com/dotnet/SqlClient/blob/main/release-notes/4.0/4.0.0.md#breaking-changes
Co-authored-by: Jonathon Rossi <jono@jonorossi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change
Microsoft.Data.SqlClientwas upgraded to >4.0.0 which introduces a breaking change regarding connection strings. If your SQL Server does not use encryption you have to explicitly specify this in the connection string by addingEncrypt=False. Otherwise the connection will fail with aSqlException. Refer to the SqlClient documentation for details.