Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supply IFormatProvider to CompactJsonFormatter/RenderedCompactJsonFormatter #55

Open
nblumhardt opened this issue Jul 19, 2023 · 0 comments
Labels

Comments

@nblumhardt
Copy link
Member

Message template rendering is culture-specific; the constructors for the included formatter types should accept an optional IFormatProvider (likely through an overload) so that consumers can opt into the locale of their choosing.

Note that v2 dev currently uses CultureInfo.InvariantCulture inline in the source code, via #54, which is a breaking change (the old default would use the current locale).

When this change is implemented, we should revert that breakage and again default to the current culture.

@nblumhardt nblumhardt added the bug label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant