Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK and targets to match Serilog 3 #54

Merged
merged 27 commits into from Jul 19, 2023
Merged

Update SDK and targets to match Serilog 3 #54

merged 27 commits into from Jul 19, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 6, 2023

updated targets to NET60 and netstandard2.0
updated to serilog 3.0.1
updated nuget pckgs in test proj

Copy link
Member

@nblumhardt nblumhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! It might be best to re-title the PR "Update SDK and targets to match Serilog 3", as the library already supports .NET 6 as-is.

Spotted a few things but otherwise think this is on the right track 👍

Build.ps1 Outdated Show resolved Hide resolved
@ghost

This comment was marked as duplicate.

@ghost ghost changed the title NET6 support Update SDK and targets to match Serilog 3 Jul 10, 2023
@ghost
Copy link
Author

ghost commented Jul 10, 2023

Hi, good to read that the direction is good and thanks for feedback :-)

I put the changes, makes sense.

Question, what do you thing about skipping net50 because of warning:
NETSDK1138: The target framework 'net5.0' is out of support and will not receive security updates


For a possible next version what do you think about replacing dependencies to Newtonsoft.Json and Newtonsoft.Json.Linq by System.Text.Json and System.Linq ?
I'd like to have less dependencies to other third party libraries and I do expect some performance improvement from System.Text.Json
I think about a proposal how to change that, if there is "green light" for that idea, I'll have a look into that :-)

@ghost
Copy link
Author

ghost commented Jul 11, 2023

@nblumhardt
just merged manually changes from dev, there are no changes on the C# code, only readme, publishing key, ...
let me know if you may spot something else :-)
thanks

@ghost
Copy link
Author

ghost commented Jul 17, 2023

@nblumhardt
Hi, I have to close the account the next days. Is there anything to change on my PR? Or you might just take my branch into your Repo?
Let me know please, anyway the changes are no "rocket science" :-)
Cheers

@nblumhardt nblumhardt changed the base branch from main to dev July 19, 2023 21:46
@nblumhardt
Copy link
Member

Thanks @pmetz-steelcase 👍

@nblumhardt nblumhardt merged commit 2db445d into serilog:dev Jul 19, 2023
1 check passed
@ghost
Copy link
Author

ghost commented Jul 20, 2023

@nblumhardt
Happy that I could help somehow. Serilog is (not only -) in my opinion the best choice for logging in .NET C#

Question, as I have to close my account pmetz-steelcase, now after it's merged I can delete my repo pmetz-steelcase:devNet6 (https://github.com/pmetz-steelcase/serilog-formatting-compact/tree/devNet6) ?

@nblumhardt
Copy link
Member

I don't think that will cause any problems - thanks Peter!

@ghost ghost deleted the devNet6 branch July 20, 2023 06:25
@nblumhardt nblumhardt mentioned this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant