-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SDK and targets to match Serilog 3 #54
Conversation
Permissions have now been updated
1.1.0 Release
updated packages in test proj
…cal project folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! It might be best to re-title the PR "Update SDK and targets to match Serilog 3", as the library already supports .NET 6 as-is.
Spotted a few things but otherwise think this is on the right track 👍
src/Serilog.Formatting.Compact/Serilog.Formatting.Compact.csproj
Outdated
Show resolved
Hide resolved
src/Serilog.Formatting.Compact/Serilog.Formatting.Compact.csproj
Outdated
Show resolved
Hide resolved
src/Serilog.Formatting.Compact/Serilog.Formatting.Compact.csproj
Outdated
Show resolved
Hide resolved
src/Serilog.Formatting.Compact/Serilog.Formatting.Compact.csproj
Outdated
Show resolved
Hide resolved
test/Serilog.Formatting.Compact.Tests/Serilog.Formatting.Compact.Tests.csproj
Outdated
Show resolved
Hide resolved
This comment was marked as duplicate.
This comment was marked as duplicate.
Hi, good to read that the direction is good and thanks for feedback :-) I put the changes, makes sense. Question, what do you thing about skipping net50 because of warning: For a possible next version what do you think about replacing dependencies to Newtonsoft.Json and Newtonsoft.Json.Linq by System.Text.Json and System.Linq ? |
…s table [skip ci], from commit 06ef9d8
@nblumhardt |
@nblumhardt |
Thanks @pmetz-steelcase 👍 |
@nblumhardt Question, as I have to close my account pmetz-steelcase, now after it's merged I can delete my repo pmetz-steelcase:devNet6 (https://github.com/pmetz-steelcase/serilog-formatting-compact/tree/devNet6) ? |
I don't think that will cause any problems - thanks Peter! |
updated targets to NET60 and netstandard2.0
updated to serilog 3.0.1
updated nuget pckgs in test proj